Added exception to event data #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful to get the exception message for a better error handling in an observer.
|
@cmuench thank you for contribution. Could you please describe use case for this new event argument? |
|
@okorshenko I wrote an order export. If the export failed for some reason like a db lock or something else i like to know the error message or i like to add i.e. an own error logger or a triggerd email. |
|
@cmuench, thank you for contribution. This PR will be merged soon in scope of MAGETWO-43521 |
|
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
|
@cmuench, thank you for contribution. Your pull request has been merged successfully. Thank you for helping us make Magento 2 better! |
magento-team
pushed a commit
that referenced
this pull request
Dec 12, 2017
Fixed issues: - MAGETWO-83631: [Backport for 2.1.x] Loaded quote items collection contains removed product items - MAGETWO-72312: Incorrect count for category filter at layered navigation for configurable with no available options - MAGETWO-69036: Lazy-loaders cause fatal errors in production mode on cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to get the exception message for a better error handling in an observer.