Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement PageLayout Config Builder. Added save in cache config files. #28818

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Improvement PageLayout Config Builder. Added save in cache config files. #28818

merged 6 commits into from
Sep 23, 2020

Conversation

Knase
Copy link
Contributor

@Knase Knase commented Jun 20, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Magento often runs getPageLayoutsConfig. I added to save in cache config files. This optimization will be reduced load time.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Improvement PageLayout Config Builder. Added save in cache config files. #29546: Improvement PageLayout Config Builder. Added save in cache config files.

@m2-assistant
Copy link

m2-assistant bot commented Jun 20, 2020

Hi @Knase. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@Knase Knase closed this Jun 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2020

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Knase Knase reopened this Jun 22, 2020
@Knase Knase closed this Jun 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2020

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Knase Knase reopened this Jun 22, 2020
@Knase Knase closed this Jun 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 23, 2020

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Knase Knase reopened this Jun 23, 2020
@Knase
Copy link
Contributor Author

Knase commented Jun 25, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Knase. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Knase, here is your Magento instance.
Admin access: https://i-28818-2-4-develop.instances.magento-community.engineering/admin_f300
Login: b7bd962e Password: 8912a59ae74b
Instance will be terminated in up to 3 hours.

@Knase
Copy link
Contributor Author

Knase commented Jun 25, 2020

@magento run all tests

@sidolov
Copy link
Contributor

sidolov commented Aug 14, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 14, 2020
Closed
4 tasks
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

@ghost ghost assigned gabrieldagama Sep 14, 2020
@magento-engcom-team magento-engcom-team added the partners-contribution Pull Request is created by Magento Partner label Sep 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8195 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Echo
Copy link
Contributor

✔️ QA passed
Result:

❌ Before:
image

✔️ After:
image

Tested protected function getConfigFiles().
On test used delay "usleep(100);", otherwise, the values time ​​is very meager.

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Sep 22, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Sep 22, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2020
@gabrieldagama
ENGCOM-8195: Improvement PageLayout Config Builder. Added save in cac…
c9a4107 
…he config files. #28818
@magento-engcom-team magento-engcom-team merged commit e877544 into magento:2.4-develop Sep 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2020

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama approved these changes

@sidolov sidolov Awaiting requested review from sidolov

Assignees

@gabrieldagama gabrieldagama

@sidolov sidolov

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Theme Partner: Guidance Solutions partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Improvement PageLayout Config Builder. Added save in cache config files.
6 participants
@Knase @magento-engcom-team @sidolov @engcom-Echo @gabrieldagama @engcom-Alfa