cart api bug fix & partial invoice credit memo divide by zero warning #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2013 16:01
…ices are properly calculated
|
Hello destination-experience, |
magento-team
added a commit
that referenced
this pull request
Nov 29, 2013
* Modularity improvements:
* Breakdown of the Adminhtml module:
* Moved Newsletter, Report logic to the respective modules
* Moved blocks, config, view, layout files of other components from Adminhtml folder to respective modules
* Removed application dependencies from the library
* Move Magento\Core common blocks in the library
* Application areas rework:
* Areas are independent from Store
* Removed deprecated annotation from the getArea methods
* GitHub requests:
* [#245](#245) -- Resolve design flaws in core URL helper
* [#247](#247) -- Bug in Mage_Page_Block_Html_Header->getIsHomePage
* [#259](#259) -- Turkish Lira (TRY) is supported for Turkish members.
* [#262](#262) -- Update Rule.php
* [#373](#373) -- [Magento/Sales] Fixed typos
* [#382](#382) -- [Magento/Core] Fixed typos
* [#304](#304) -- Removed Erroneous closing "
* [#323](#323) -- InstanceController.php - made setBody protected
* [#349](#349) -- Move Mage_Catalog menu declaration into Mage_Catalog module.
* [#265](#265) -- Update Merge.php
* [#271](#271) -- Check Data should validate gallery information
* [#305](#305) -- Extra ", tidied up nested quotes
* [#352](#352) -- Add Croatia Country as part of European Union since 1st July 2013 for default european local countries in configuration
* [#224](#224) -- Tax formatting is locale aware and should not
* [#338](#338) -- Correcting SQL for required_options column
* [#327](#327) -- cart api bug fix & partial invoice credit memo divide by zero warning
* Themes update:
* Old frontend (magento_demo) and backend (magento_basic) themes are removed
* Updated templates and layout updates in the Bundle, Catalog, CatalogInventory, CatalogSearch, Downloadable, ProductAlert, Reports, Sendfriend modules
* Fixed bugs:
* Fixed the error when Magento cannot be reinstalled to the same database with table prefix
* Fixed report Products in Cart
* Fixed error on attempt to insert image to CMS pages under version control
* Fixed order status grid so that you can assign state, edit, and view custom order status
* Fixed Related Products Rule page so that category can be selected on conditions tab
* Fixed Magento_Paypal_Controller_ExpressTest integration test so it is re-enabled
* Fixed the bug with international DHL quotes
|
destination-experience, |
magento-team
pushed a commit
that referenced
this pull request
Jan 20, 2016
[PHP7 Indexer]: Remi PHP 7.0.1 failure on L1 segmentation fault on SOAP / REST
okorshenko
pushed a commit
that referenced
this pull request
Dec 14, 2016
Story: - MAGETWO-57905: Compiler Performance Optimization for 2.1
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry i didnt realize committing here would add the change to the pull request. There are two issuses here now. Let me know if you want me to try and sort them apart.
The cart api doesnt properly save a price when shoppingCartProductAdd() is called. The reason is because no addresses are stored for the quote. This fixes that by adding a call to getBillingAddress() and getShippingAddress() in shoppingCartCreate().
If you have an order with multiple items on it and invoice just one of those items. Then, trying to create a credit memo for that order causes a divide by zero warning in two different files. The issue here is that the credit memo assumes all the items have been invoiced. I created a fix by just checking the number of invoiced items.