Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type checking to the toolbar model to fix type error #37854

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Added type checking to the toolbar model to fix type error #37854

wants to merge 1 commit into from

Conversation

jenyatrishin
Copy link

Description (*)

Fixed type error on the category page when product_list_order parameter is an array.
Added type validation for product_list_order request parameter and if this parameter is not string or bollean boolean 'false' will be returned.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Noticed exception 'TypeError' when the product_list_order parameter is an array. #37827

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 7, 2023

Hi @jenyatrishin. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Aug 7, 2023
@m2-community-project m2-community-project bot added Progress: pending review Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 7, 2023
@jenyatrishin jenyatrishin changed the title added type checking to the toolbar model to fix type error Added type checking to the toolbar model to fix type error Aug 13, 2023
@jenyatrishin jenyatrishin reopened this Aug 13, 2023
@jenyatrishin
Copy link
Author

@magento run Database Compare

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@jenyatrishin
Copy link
Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@jenyatrishin
Copy link
Author

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@jenyatrishin
Copy link
Author

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@jenyatrishin
Copy link
Author

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@jenyatrishin
Copy link
Author

@magento run Magento Health Index

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@jenyatrishin
Copy link
Author

@magento run Sample Data Tests B2B

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@jenyatrishin
Copy link
Author

@magento run Sample Data Tests B2B

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@jenyatrishin
Copy link
Author

@magento run Sample Data Tests B2B

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
Pull Requests Dashboard
Status: Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noticed exception 'TypeError' when the product_list_order parameter is an array.
1 participant
@jenyatrishin