Fix of "Internal classes cannot be mocked without invoking their constructor in PHP 5.4.29/5.5.13" unit tests failure on Travis CI #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructor in PHP 5.4.29" unit tests failure on Travis CI
…tructor in PHP 5.4.29" unit tests failure on Travis CI - fix issues appeared due to incomplete fix: -- Argument 1 passed to Magento\Backend\Model\Menu::__construct() must be an instance of Magento\Framework\Logger, none given -- DOMException: DOMElement::__construct() expects at least 1 parameter, 0 given
|
@orlangur, thank you for your contribution! We have deployed the code in version dev87. We are closing this pull request. |
magento-team
pushed a commit
that referenced
this pull request
Oct 21, 2015
[Merchant Beta][MX] Bugfixes
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 25, 2016
MAGETWO-61132: Integration test Magento\Directory\Model\ObserverTest fails due to 3rd party service outage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the fix builds are green: https://travis-ci.org/orlangur/magento2