Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipping method radios become disabled when checkout page refreshed #9485

Merged
merged 2 commits into from
May 3, 2017
Merged

Shipping method radios become disabled when checkout page refreshed #9485

merged 2 commits into from
May 3, 2017

Conversation

rachkulik
Copy link

@rachkulik rachkulik commented May 3, 2017 •
edited by ishakhsuvarov
Loading

  • Backport fix MAGETWO-56073

Fixed Issues (if relevant)

  1. Shipping method radios become disabled when checkout page refreshed #7497: Shipping method radios become disabled when checkout page refreshed

Manual testing scenarios

For Guests

  • Add product to the cart
  • Proceed to checkout as a guest
  • Enter valid address details
  • Wait for shipping rates to be displayed
  • Refresh page (Ctrl + R for example)

For Registred Users

  • Sign into an existing (or create a new) customer account with an address in the address book
  • Add one or more items to the shopping cart
  • Click Checkout in the mini cart
  • Click the New Address button on the shipping page
  • Complete the new address form and submit

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@rachkulik
magento#7497 - Shipping method radios become disabled when checkout p…
d82f3ea 
…age refreshed

 - Backport fix MAGETWO-56073
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 3, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this May 3, 2017
ishakhsuvarov
ishakhsuvarov requested changes May 3, 2017
View reviewed changes
app/code/Magento/Checkout/view/frontend/web/js/model/new-customer-address.js
regionId;

if (addressData.region && addressData.region.region_id) {
regionId = addressData.region.region_id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure regionId is used.

@ishakhsuvarov ishakhsuvarov added this to the May 2017 milestone May 3, 2017
@magento-team magento-team merged commit 8c33f68 into magento:2.1-develop May 3, 2017
magento-team pushed a commit that referenced this pull request May 3, 2017
@ishakhsuvarov
MAGETWO-68875: Shipping method radios become disabled when checkout p…
75e490c 
…age refreshed #9485
magento-team pushed a commit that referenced this pull request May 3, 2017
@ishakhsuvarov
Merge pull request #1078 from magento-engcom/2.1-develop-prs
fa68470 
[EngCom] Public Pull Requests - 2.1

 - MAGETWO-68875: [Backport] Shipping method radios become disabled when checkout page refreshed #9485
@magento-team
Copy link
Contributor

@rachkulik thank you for your contribution. Your Pull Request has been successfully merged

@1408sheva 1408sheva mentioned this pull request Jul 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishakhsuvarov ishakhsuvarov ishakhsuvarov approved these changes

Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Release Line: 2.1
Projects
None yet
Milestone
May 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@rachkulik @magento-cicd2 @magento-team @ishakhsuvarov