Make unary "-" work with @tf #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
=====================================
Coverage 48% 48%
=====================================
Files 79 79
Lines 2652 2652
=====================================
Hits 1273 1273
Misses 1379 1379
Continue to review full report at Codecov.
|
|
Thanks for this. I didn't know it was borked. Can you add a test for this in test/meta.jl Also I am pretty sure it needs a |
|
Not sure why Travis is segfaulting in the python 3 instances, I'm using python 3 locally and everything related to this PR seems to work. |
|
I have kicked it to retry. |
|
The same failure seems to happen since a month. See #435 |
|
Well fair enough, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, it errors because of the
namekeyword when used with@tf.