Run unit tests for iOS code on CI server #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dersim-davaod
added
enhancement
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
dersim-davaod
force-pushed
the
109-run-unit-tests-for-ios
branch
from
131f9b0
to
22fa6a1
Compare
dersim-davaod
force-pushed
the
109-run-unit-tests-for-ios
branch
3 times, most recently
from
e7d5b47
to
04eb44f
Compare
dersim-davaod
changed the base branch from
dev
to
156-setup-travis-ci-to-have-a-build-jobs
dersim-davaod
requested review from
chezzdev,
AlekseiCherkes and
IodaMikeMapbox
and removed request for
AlekseiCherkes
dersim-davaod
force-pushed
the
109-run-unit-tests-for-ios
branch
from
8b5fe2c
to
04eb44f
Compare
dersim-davaod
changed the base branch from
156-setup-travis-ci-to-have-a-build-jobs
to
dev
dersim-davaod
changed the base branch from
dev
to
156-setup-travis-ci-to-have-a-build-jobs
| @@ -55,6 +55,11 @@ jobs: | |||
| - IOS_BUILD_TYPE='Debug' | |||
There was a problem hiding this comment.
let's rename the job to something like Debug / Tests / Simulator / Xcode 11.2
There was a problem hiding this comment.
What about
iOS / Debug (Tests) / Simulator / Xcode 11.2
instead of
iOS / Debug / Simulator / Xcode 11.2?
| @@ -55,6 +55,11 @@ jobs: | |||
| - IOS_BUILD_TYPE='Debug' | |||
| - IOS_PLATFORM_TYPE='iphonesimulator' | |||
| - DST='platform=iOS Simulator,OS=13.2.2,name=iPhone 11' | |||
| script: | |||
| - scripts/ci/build.sh --build MapboxVision | |||
There was a problem hiding this comment.
I think the tests will build MapboxVision as a dependency, there is no need to waste time on a standalone build
dersim-davaod
force-pushed
the
156-setup-travis-ci-to-have-a-build-jobs
branch
from
b4a676f
to
2982213
Compare
dersim-davaod
force-pushed
the
109-run-unit-tests-for-ios
branch
from
568fe3b
to
a39cb36
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: branch has been branched off from the
156-setup-travis-ci-to-have-a-build-jobsbranch. It's more convenient to see the diff.That means we'd prefer to merge #240 first and then I will change the base branch.
Here's the test results: https://travis-ci.com/github/mapbox/mapbox-vision-ios/builds/159633808
Checks:
devbranchLinked issues:
Resolves #109