Use tap #314
Closed
Use tap #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings node-pre-gyp into a more modern age of tar parsing and creation. Node-tar v3 is faster and more reliable, and removes several race conditions that were inherent in the fstream utility. This also removes the need for some workarounds to force directories to be readable. It also uses the npm-packlist module to decide what to put into a package, which will be used by npm itself relatively soon. Tar version 3 is only supported by node v4 and above, as it uses modern ES class and fat-arrow syntax. Thus, this is a breaking change, worthy of a semver major version bump, but it only leaves less than 10% of our users behind. (And folks who don't update Node.js out of unmaintained versions are unlikely to upgrade node-pre-gyp anyway.) The only change I'm somewhat unsure about is the use of the "portable" flag in tar.create here. This excludes system-specific items like username, uid, ctime, etc., resulting in a tarball that is 100% dependent on the contents and mtime of the items it includes. Of course, mtime will change if the package is rebuilt, but this means that multiple calls to `node-pre-gyp package` will not result in different bits on disk.
Closed
Also, coverage! Not very good right now, but could be improved over time.
|
we've been doing okay with tape, so not planning on working to update/land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Land after #299
Supersedes #313