Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use with for json modules instead of assert #675

Merged
merged 2 commits into from
May 20, 2024

Conversation

jleedev
Copy link
Contributor

@jleedev jleedev commented May 20, 2024

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (c6bec09) to head (d45f57b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         104      104           
  Lines        4624     4624           
  Branches     1303     1303           
=======================================
  Hits         4275     4275           
  Misses        349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented May 20, 2024

Can you add a changelog item please?

@HarelM
Copy link
Collaborator

HarelM commented May 20, 2024

THANKS!

@HarelM HarelM merged commit 054d503 into maplibre:main May 20, 2024
6 checks passed
@jleedev jleedev deleted the import-assertions branch May 20, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants