Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use integers and not numbers in notification policy API counters #29810

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Use integers and not numbers in notification policy API counters #29810

merged 1 commit into from
Apr 2, 2024

Conversation

renchap
Copy link
Sponsor Member

@renchap renchap commented Mar 29, 2024

I could not find a reason for those to be strings. They will never be large enough to not fit an integer, and this is a cleaner interface

@renchap renchap force-pushed the notification-policy-numbers branch from 90fa041 to 15b6578 Compare April 2, 2024 09:34
ClearlyClaire
ClearlyClaire approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an ok change since the API is not finalized or documented yet.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Apr 2, 2024
Merged via the queue into mastodon:main with commit b4d991a Apr 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renchap @ClearlyClaire