Cache QueryATNF object #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if caching the database, rather than just caching the ATNF catalogue tarball, this caches the actual QueryATNF object. This greatly speeds up reuse.
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 75.32% 75.10% -0.23%
==========================================
Files 7 7
Lines 3157 3177 +20
Branches 548 555 +7
==========================================
+ Hits 2378 2386 +8
- Misses 562 571 +9
- Partials 217 220 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if caching (the default) using the
QueryATNFobject, it actually only caches the downloaded ATNF catalogue tarball. When generating new queries usingQueryATNF, even using this cached file can take a few to tens of second to load (due partly to having to recalculate all the derived parameters. This PR instead caches and re-loaded theQueryATNFobject itself, which is considerably quicker.The default location of the cache objects has also been changed to be in a
~/.psrqpydirectory.This supersedes #102.