Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to parse the globular cluster pulsar table #77

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Conversation

mattpitkin
Copy link
Owner

This closes #9

@pep8speaks
Copy link

pep8speaks commented Mar 18, 2021

Hello @mattpitkin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-18 10:51:12 UTC

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #77 (c1099d0) into master (3208300) will increase coverage by 0.81%.
The diff coverage is 89.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   68.59%   69.41%   +0.81%     
==========================================
  Files           5        5              
  Lines        2404     2501      +97     
  Branches      490      510      +20     
==========================================
+ Hits         1649     1736      +87     
- Misses        554      559       +5     
- Partials      201      206       +5     
Impacted Files Coverage Δ
psrqpy/utils.py 53.37% <89.32%> (+5.66%) ⬆️
psrqpy/config.py 100.00% <100.00%> (ø)
psrqpy/search.py 75.34% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3208300...c1099d0. Read the comment docs.

@mattpitkin mattpitkin merged commit 6eb7603 into master Mar 18, 2021
@mattpitkin mattpitkin deleted the gctable branch March 18, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe add querying of the Globular Cluster table
2 participants