Fix parsing of galactic MSP table following changes to galmsp repo #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattpitkin my bad 😅! I was about to fix this with a PR myself but it completely slipped my mind. Good that you have got it done in this one 👍🏾 ! I made the change after checking out your code for parsing my table, and thought it would be a good idea if the field names followed ATNF from the very beginning. If there are any other changes like this one, I will let you know beforehand next time 😁 ! |
|
@astrogewgaw no problem. I spotted the problem when I noticed the CI failed after my last minor update. A heads up about future changes would be very much appreciated though. |
|
@mattpitkin sure thing 👍🏾 😁 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that values are stored in the galmsp table changed (see 8a6b1be6). This broke how psrqpy parsed the data, which has now been fixed in this PR.