Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh packaging #24

Merged
merged 3 commits into from
Jun 12, 2024
Merged

refresh packaging #24

merged 3 commits into from
Jun 12, 2024

Conversation

mbdevpl
Copy link
Owner

@mbdevpl mbdevpl commented Jun 12, 2024

No description provided.

@mbdevpl mbdevpl self-assigned this Jun 12, 2024
@jenkins-mbdev
Copy link

jenkins-mbdev bot commented Jun 12, 2024

Tools report for GitHub-mbdevpl/ingit/PR-24 [build #1]:

  • Pylint: warnings ⚠️ (click for details)
    ************* Module ingit.action_progress
    ingit/action_progress.py:30:24: W0511: TODO: works only in bash, but what about cmd? (fixme)
    ************* Module ingit.runtime_interface
    ingit/runtime_interface.py:70:5: W0511: TODO: put this function in some library (fixme)
    ingit/runtime_interface.py:34:0: R1260: 'ask' is too complex. The McCabe rating is 11 (too-complex)
    ************* Module ingit.runtime
    ingit/runtime.py:214:17: W0511: TODO: recurse into non-git dir here (fixme)
    ingit/runtime.py:196:4: R1260: '_unregistered_folders_summary' is too complex. The McCabe rating is 13 (too-complex)
    ingit/runtime.py:252:4: R1260: 'register_repository' is too complex. The McCabe rating is 12 (too-complex)
    ingit/runtime.py:34:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes)
    ingit/runtime.py:259:8: W0717: try clause contains 4 statements, expected at most 1 (too-many-try-statements)
    ingit/runtime.py:266:16: W0717: try clause contains 4 statements, expected at most 1 (too-many-try-statements)
    ************* Module ingit.repo_data
    ingit/repo_data.py:13:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)
    ingit/repo_data.py:68:8: W0717: try clause contains 2 statements, expected at most 1 (too-many-try-statements)
    ************* Module ingit.project
    ingit/project.py:498:4: R1260: '_status_remotes' is too complex. The McCabe rating is 12 (too-complex)
    ingit/project.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)
    ingit/project.py:108:8: W0717: try clause contains 3 statements, expected at most 1 (too-many-try-statements)
    ingit/project.py:182:8: W0717: try clause contains 3 statements, expected at most 1 (too-many-try-statements)
    ingit/project.py:254:4: R0914: Too many local variables (16/15) (too-many-locals)
    ingit/project.py:263:26: W0212: Access to a protected member _repo of a client class (protected-access)
    ingit/project.py:279:19: W0212: Access to a protected member _repo of a client class (protected-access)
    ingit/project.py:366:8: W0717: try clause contains 3 statements, expected at most 1 (too-many-try-statements)
    ingit/project.py:439:4: R6301: Method could be a function (no-self-use)
    ingit/project.py:473:8: W0702: No exception type(s) specified (bare-except)
    
    -----------------------------------
    Your code has been rated at 9.88/10
    
  • Mypy: problems ⚠️ (click for details)
    ingit/runtime_interface.py:34: error: Incompatible default for argument "answers" (default has type "None", argument has type "Sequence[str]")  [assignment]
    ingit/runtime_interface.py:34: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    ingit/runtime_interface.py:34: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    ingit/runtime_interface.py:35: error: Incompatible default for argument "autoanswer" (default has type "None", argument has type "bool | str")  [assignment]
    ingit/runtime_interface.py:35: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    ingit/runtime_interface.py:35: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    ingit/repo_data.py:69: error: Function "branches" could always be true in boolean context  [truthy-function]
    ingit/repo_data.py:75: error: List item 0 has incompatible type "tuple[str, None]"; expected "tuple[str, Reference]"  [list-item]
    ingit/repo_data.py:76: error: "Callable[[], IterableList[Head]]" has no attribute "__iter__" (not iterable)  [attr-defined]
    ingit/repo_data.py:80: error: Value expression in dictionary comprehension has incompatible type "tuple[str, ...] | None"; expected type "Reference"  [misc]
    ingit/repo_data.py:86: error: List item 0 has incompatible type "tuple[str, None]"; expected "tuple[str, Remote]"  [list-item]
    ingit/repo_data.py:90: error: Key expression in dictionary comprehension has incompatible type "tuple[str, str]"; expected type "str"  [misc]
    ingit/project.py:112: error: Argument "progress" to "clone_from" of "Repo" has incompatible type "ActionProgress"; expected "Callable[[int, str | float, str | float | None, str], None] | None"  [arg-type]
    ingit/project.py:276: error: Incompatible types in assignment (expression has type "tuple[str, None]", target has type "tuple[Any, str]")  [assignment]
    ingit/runtime.py:38: error: Incompatible default for argument "hostname" (default has type "None", argument has type "str")  [assignment]
    ingit/runtime.py:38: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    ingit/runtime.py:38: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    Found 11 errors in 4 files (checked 24 source files)
    
  • Flake518: problems ⚠️ (click for details)
    ingit/project.py:473:9: E722 do not use bare 'except'
    
  • Pydocstyle: ran 🆗

  • Coverage: 93% 🆗 (click for details)
    Name                             Stmts   Miss Branch BrPart  Cover   Missing
    ----------------------------------------------------------------------------
    ingit/__init__.py                    2      0      0      0   100%
    ingit/__main__.py                    9      0      2      0   100%
    ingit/_version.py                    2      0      0      0   100%
    ingit/action_progress.py            77      2     28      0    98%   60-61
    ingit/fetch_flags.py                27      3     10      3    84%   39, 48, 51
    ingit/json_config.py                57      0      6      0   100%
    ingit/main.py                       99      6     34      1    95%   234-235, 256-259
    ingit/project.py                   372     63    168     25    81%   74-75, 114-115, 150->152, 167-177, 186-187, 190, 198, 208, 250, 286, 288, 298->305, 299->298, 312-314, 331, 349, 371-372, 380, 391->393, 397-398, 409-410, 417-418, 435-436, 441-452, 460->462, 473-477, 480, 486, 520-521, 527-528, 532-533, 536, 550-553, 555
    ingit/push_flags.py                 15      0      4      1    95%   35->37
    ingit/repo_data.py                  64      3     20      0    96%   43-44, 52
    ingit/runtime.py                   208     24     92      8    87%   62-64, 103, 153-154, 158-166, 175, 180->182, 190, 205-206, 228->exit, 275-276, 284-285, 294, 298->300
    ingit/runtime_interface.py          57      2     24      2    95%   66, 78
    setup.py                            11      0      2      0   100%
    test/__init__.py                     5      0      0      0   100%
    test/test_action_progress.py       135      0     22      0   100%
    test/test_git_commands.py          141      0     28      1    99%   46->48
    test/test_ingit_commands.py         95      0     30      0   100%
    test/test_json_config.py            50      0     26      0   100%
    test/test_main.py                   37      0     18      0   100%
    test/test_packaging.py               3      0      0      0   100%
    test/test_project.py               190      0     48      0   100%
    test/test_repo_data.py              39      0      0      0   100%
    test/test_runtime.py                66      0     28      0   100%
    test/test_runtime_interface.py      25      0     16      0   100%
    ----------------------------------------------------------------------------
    TOTAL                             1786    103    606     41    93%
    

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (6b1b4ab) to head (cdd64cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          24       24           
  Lines        1786     1786           
  Branches      303      303           
=======================================
  Hits         1642     1642           
  Misses        103      103           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-mbdev
Copy link

jenkins-mbdev bot commented Jun 12, 2024

Tools report for GitHub-mbdevpl/ingit/PR-24 [build #2]:

  • Pylint: warnings ⚠️ (click for details)
    ************* Module ingit.runtime
    ingit/runtime.py:214:17: W0511: TODO: recurse into non-git dir here (fixme)
    ingit/runtime.py:196:4: R1260: '_unregistered_folders_summary' is too complex. The McCabe rating is 13 (too-complex)
    ingit/runtime.py:252:4: R1260: 'register_repository' is too complex. The McCabe rating is 12 (too-complex)
    ingit/runtime.py:34:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes)
    ingit/runtime.py:259:8: W0717: try clause contains 4 statements, expected at most 1 (too-many-try-statements)
    ingit/runtime.py:266:16: W0717: try clause contains 4 statements, expected at most 1 (too-many-try-statements)
    ************* Module ingit.project
    ingit/project.py:498:4: R1260: '_status_remotes' is too complex. The McCabe rating is 12 (too-complex)
    ingit/project.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)
    ingit/project.py:108:8: W0717: try clause contains 3 statements, expected at most 1 (too-many-try-statements)
    ingit/project.py:182:8: W0717: try clause contains 3 statements, expected at most 1 (too-many-try-statements)
    ingit/project.py:254:4: R0914: Too many local variables (16/15) (too-many-locals)
    ingit/project.py:263:26: W0212: Access to a protected member _repo of a client class (protected-access)
    ingit/project.py:279:19: W0212: Access to a protected member _repo of a client class (protected-access)
    ingit/project.py:366:8: W0717: try clause contains 3 statements, expected at most 1 (too-many-try-statements)
    ingit/project.py:439:4: R6301: Method could be a function (no-self-use)
    ingit/project.py:473:8: W0702: No exception type(s) specified (bare-except)
    ************* Module ingit.repo_data
    ingit/repo_data.py:13:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)
    ingit/repo_data.py:68:8: W0717: try clause contains 2 statements, expected at most 1 (too-many-try-statements)
    ************* Module ingit.runtime_interface
    ingit/runtime_interface.py:70:5: W0511: TODO: put this function in some library (fixme)
    ingit/runtime_interface.py:34:0: R1260: 'ask' is too complex. The McCabe rating is 11 (too-complex)
    ************* Module ingit.action_progress
    ingit/action_progress.py:30:24: W0511: TODO: works only in bash, but what about cmd? (fixme)
    
    -----------------------------------
    Your code has been rated at 9.88/10
    
  • Mypy: problems ⚠️ (click for details)
    ingit/runtime_interface.py:34: error: Incompatible default for argument "answers" (default has type "None", argument has type "Sequence[str]")  [assignment]
    ingit/runtime_interface.py:34: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    ingit/runtime_interface.py:34: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    ingit/runtime_interface.py:35: error: Incompatible default for argument "autoanswer" (default has type "None", argument has type "bool | str")  [assignment]
    ingit/runtime_interface.py:35: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    ingit/runtime_interface.py:35: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    ingit/repo_data.py:69: error: Function "branches" could always be true in boolean context  [truthy-function]
    ingit/repo_data.py:75: error: List item 0 has incompatible type "tuple[str, None]"; expected "tuple[str, Reference]"  [list-item]
    ingit/repo_data.py:76: error: "Callable[[], IterableList[Head]]" has no attribute "__iter__" (not iterable)  [attr-defined]
    ingit/repo_data.py:80: error: Value expression in dictionary comprehension has incompatible type "tuple[str, ...] | None"; expected type "Reference"  [misc]
    ingit/repo_data.py:86: error: List item 0 has incompatible type "tuple[str, None]"; expected "tuple[str, Remote]"  [list-item]
    ingit/repo_data.py:90: error: Key expression in dictionary comprehension has incompatible type "tuple[str, str]"; expected type "str"  [misc]
    ingit/project.py:112: error: Argument "progress" to "clone_from" of "Repo" has incompatible type "ActionProgress"; expected "Callable[[int, str | float, str | float | None, str], None] | None"  [arg-type]
    ingit/project.py:276: error: Incompatible types in assignment (expression has type "tuple[str, None]", target has type "tuple[Any, str]")  [assignment]
    ingit/runtime.py:38: error: Incompatible default for argument "hostname" (default has type "None", argument has type "str")  [assignment]
    ingit/runtime.py:38: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    ingit/runtime.py:38: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    Found 11 errors in 4 files (checked 24 source files)
    
  • Flake518: problems ⚠️ (click for details)
    ingit/project.py:473:9: E722 do not use bare 'except'
    
  • Pydocstyle: ran 🆗

  • Coverage: 93% 🆗 (click for details)
    Name                             Stmts   Miss Branch BrPart  Cover   Missing
    ----------------------------------------------------------------------------
    ingit/__init__.py                    2      0      0      0   100%
    ingit/__main__.py                    9      0      2      0   100%
    ingit/_version.py                    2      0      0      0   100%
    ingit/action_progress.py            77      2     28      0    98%   60-61
    ingit/fetch_flags.py                27      3     10      3    84%   39, 48, 51
    ingit/json_config.py                57      0      6      0   100%
    ingit/main.py                       99      6     34      1    95%   234-235, 256-259
    ingit/project.py                   372     63    168     25    81%   74-75, 114-115, 150->152, 167-177, 186-187, 190, 198, 208, 250, 286, 288, 298->305, 299->298, 312-314, 331, 349, 371-372, 380, 391->393, 397-398, 409-410, 417-418, 435-436, 441-452, 460->462, 473-477, 480, 486, 520-521, 527-528, 532-533, 536, 550-553, 555
    ingit/push_flags.py                 15      0      4      1    95%   35->37
    ingit/repo_data.py                  64      3     20      0    96%   43-44, 52
    ingit/runtime.py                   208     24     92      8    87%   62-64, 103, 153-154, 158-166, 175, 180->182, 190, 205-206, 228->exit, 275-276, 284-285, 294, 298->300
    ingit/runtime_interface.py          57      2     24      2    95%   66, 78
    setup.py                            11      0      2      0   100%
    test/__init__.py                     5      0      0      0   100%
    test/test_action_progress.py       135      0     22      0   100%
    test/test_git_commands.py          141      0     28      1    99%   46->48
    test/test_ingit_commands.py         95      0     30      0   100%
    test/test_json_config.py            50      0     26      0   100%
    test/test_main.py                   37      0     18      0   100%
    test/test_packaging.py               3      0      0      0   100%
    test/test_project.py               190      0     48      0   100%
    test/test_repo_data.py              39      0      0      0   100%
    test/test_runtime.py                66      0     28      0   100%
    test/test_runtime_interface.py      25      0     16      0   100%
    ----------------------------------------------------------------------------
    TOTAL                             1786    103    606     41    93%
    

@mbdevpl mbdevpl merged commit 64dd444 into main Jun 12, 2024
21 checks passed
@mbdevpl mbdevpl deleted the feature/refresh-packaging branch June 12, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant