Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy env to bashrc and use -l with cron #77

Merged
merged 7 commits into from
Feb 14, 2021

Conversation

mbround18
Copy link
Owner

@mbround18 mbround18 commented Feb 14, 2021

Description

Contributions

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18 mbround18 added the docker Tag if its related to docker label Feb 14, 2021
@D0tty
Copy link

D0tty commented Feb 14, 2021

Not on my computer as it's 4AM here 😅
But I had a quick look an it should work fine! 😀

Though it works I think a cleaner alternative IMO would be to put the environment variables directly in the cronjob (https://stackoverflow.com/a/10657111/12792224). What do you think?

@neovatar
Copy link

I second @D0tty - putting the ENV variables into the cronjob might be a cleaner solution.

@mbround18
Copy link
Owner Author

Adding that now :)

@mbround18 mbround18 merged commit 2e3f1b2 into main Feb 14, 2021
@mbround18 mbround18 deleted the mbround18/74-config-from-docker-compose-gets-ignor branch February 14, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Tag if its related to docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config from docker-compose gets ignored after automatic restart
4 participants