Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a test case for char-grouped streams #25

Merged
merged 1 commit into from
Feb 24, 2019
Merged

test: add a test case for char-grouped streams #25

merged 1 commit into from
Feb 24, 2019

Conversation

matfax
Copy link
Contributor

@matfax matfax commented Feb 23, 2019

Given the other test cases, I could not determine if split supports such a use case in that chunks are split in-line.

Given the other test cases, I could not determine if split supports such a use case in that chunks are split in-line.
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

good work, is this matching your expectations, right?

@matfax
Copy link
Contributor Author

matfax commented Feb 24, 2019

@mcollina Yes, the test fulfills my expectations. I use split2 for Cloudflare Workers, btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants