Fix \todo could not be ignored

Fixes valentjn/vscode-ltex#63.
me-johnomar · Jun 23, 2020 · 9b5c75f · 9b5c75f
1 parent cacdcc0
commit 9b5c75f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/ltexls-core/src/main/java/org/bsplines/ltexls/parsing/latex/LatexFragmentizer.java b/ltexls-core/src/main/java/org/bsplines/ltexls/parsing/latex/LatexFragmentizer.java
@@ -48,6 +48,11 @@ public List<CodeFragment> fragmentize(String code) {
         List<Pair<Integer, Integer>> arguments = null;
 
         for (LatexCommandSignature extraCommandSignature : extraCommandSignatures) {
+          if (commentFragment.getSettings().getIgnoreCommandPrototypes().contains(
+                extraCommandSignature.getCommandPrototype())) {
+            continue;
+          }
+
           arguments = extraCommandSignature.matchArgumentsFromPosition(code, fromPos);
           if (arguments != null) break;
         }

diff --git a/ltexls-core/src/test/java/org/bsplines/ltexls/parsing/latex/LatexFragmentizerTest.java b/ltexls-core/src/test/java/org/bsplines/ltexls/parsing/latex/LatexFragmentizerTest.java
@@ -1,5 +1,6 @@
 package org.bsplines.ltexls.parsing.latex;
 
+import java.util.Arrays;
 import java.util.List;
 import org.bsplines.ltexls.Settings;
 import org.bsplines.ltexls.parsing.CodeFragment;
@@ -48,6 +49,17 @@ private static void testCodeLanguage(String codeLanguageId) {
   @Test
   public void testLatex() {
     testCodeLanguage("latex");
+
+    {
+      Settings settings = new Settings();
+      settings.setIgnoreCommandPrototypes(Arrays.asList(new String[]{"\\todo{}"}));
+      CodeFragmentizer fragmentizer = CodeFragmentizer.create("latex", settings);
+      List<CodeFragment> codeFragments = fragmentizer.fragmentize(
+          "Sentence\\footnote[abc]{Footnote} 1\n"
+          + "\t\t  %\t ltex: language=de-DE\nSentence 2\\todo{Todo note}\n"
+          + "%ltex:\tlanguage=en-US\n\nSentence 3\n");
+      Assertions.assertEquals(4, codeFragments.size());
+    }
   }
 
   @Test