Ingredient suggestions 1 #8174
Ingredient suggestions 1 #8174
Conversation
src/datagen/main/java/mekanism/common/recipe/impl/ControlCircuitRecipeProvider.java
Outdated
Show resolved
Hide resolved
|
Using ingots: using 3x infusion: |
thiakil
force-pushed
the
ingredient-suggestions-1
branch
from
7189974
to
5769ff9
Compare
There was a problem hiding this comment.
Overall looks quite good. One minor thought is do we want to adjust in MekanismEmiDefaults which circuit recipe we declare as defaults? Personally I think leaving them as is probably makes the most sense, as users can switch them over to these new recipes if they want, but I figured I would bring it up here.
| @@ -64,6 +64,11 @@ public void addRecipes(RecipeOutput consumer, HolderLookup.Provider registries) | |||
| IngredientCreatorAccess.infusionStack().from(MekanismAPITags.InfuseTypes.CARBON, 10), | |||
| MekanismItems.ENRICHED_IRON.getItemStack() | |||
| ).build(consumer, Mekanism.rl(basePath + "iron/enriched")); | |||
| ItemStackChemicalToItemStackRecipeBuilder.metallurgicInfusing( | |||
| IngredientCreatorAccess.item().from(MekanismTags.Items.PROCESSED_RESOURCES.get(ResourceType.DUST, PrimaryResource.IRON)), | |||
There was a problem hiding this comment.
Do we want to add a second recipe like this, or just make the first recipe use an an or (compound) ingredient? I am fine with either. If you do decide to use an or ingredient you can use one of our helpers: BaseRecipeProvider.createIngredient, which you can see how we do it in how we add the recipes that create carbon.
I sort of think it makes more sense for it to just be a single recipe. But I am leaving that up to you.
There was a problem hiding this comment.
Maybe we can merge it later if we remember. Separate for now would promote visibility?
There was a problem hiding this comment.
Up to you, though I don't think the visibility is that bad given the fact there is basically only ever one iron ingot in modded playthroughs, and then it just cycles between the two inputs.
There was a problem hiding this comment.
I think I am going to merge them for now. Visibility doesn't seem that bad to me for the above stated reason
There was a problem hiding this comment.
Actually scratch that, I didn't think about the fact that whil ethere is only one iron ingot, there are often multiple iron dusts.
src/datagen/main/java/mekanism/common/recipe/impl/ControlCircuitRecipeProvider.java
Outdated
Show resolved
Hide resolved
pupnewfster
force-pushed
the
ingredient-suggestions-1
branch
from
c3b7fac
to
8723297
Compare
Changes proposed in this pull request:
Open to suggestions/changes