Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add melange-json-native pkg #12

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Add melange-json-native pkg #12

merged 3 commits into from
Aug 28, 2024

Conversation

jchavarri
Copy link
Member

While using this PPX internally, we figured out we don't want to impose native users the dependency on melange.

In a similar way, this split allows Melange-only users to not depend on yojson.

@jchavarri jchavarri changed the title Add melange-json-native pkg Add melange-json-native pkg Aug 27, 2024
andreypopp
andreypopp approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@andreypopp andreypopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

maybe add a few lines to README on what is this new package and how to use it?

@jchavarri
Copy link
Member Author

Good point, added in 8aa9560.

@jchavarri jchavarri merged commit 8a7a46f into main Aug 28, 2024
7 checks passed
@jchavarri jchavarri deleted the add-native-pkg branch August 28, 2024 08:37
jchavarri added a commit to jchavarri/opam-repository that referenced this pull request Aug 28, 2024
@jchavarri
[new release] melange-json (2 packages) (1.3.0)
bb61c36 
CHANGES:

- PPX: Qualify usages of infix operators with `Stdlib`
  ([melange-community/melange-json#11](melange-community/melange-json#11))
- Add `melange-json-native` package
  ([melange-community/melange-json#12](melange-community/melange-json#12))
@jchavarri jchavarri mentioned this pull request Aug 28, 2024
Merged
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
@jchavarri @avsm
[new release] melange-json (2 packages) (1.3.0)
88f7656 
CHANGES:

- PPX: Qualify usages of infix operators with `Stdlib`
  ([melange-community/melange-json#11](melange-community/melange-json#11))
- Add `melange-json-native` package
  ([melange-community/melange-json#12](melange-community/melange-json#12))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreypopp andreypopp andreypopp approved these changes

@anmonteiro anmonteiro anmonteiro approved these changes

@davesnx davesnx Awaiting requested review from davesnx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchavarri @andreypopp @anmonteiro