Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AST reflection #213

Merged
merged 9 commits into from
Jan 11, 2018
Merged

Implement AST reflection #213

merged 9 commits into from
Jan 11, 2018

Conversation

krame505
Copy link
Member

@krame505 krame505 commented Jan 4, 2018

This implements the reflectAST operation as described in #212. Next up is reify.

@krame505 krame505 requested a review from tedinski January 4, 2018 22:04
@krame505
Copy link
Member Author

@tedinski @ericvanwyk Anything that I should fix before merging this?

public abstract String[] getAnnoNames();

/**
* Used for debugging, stack traces especially.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text from copy and paste?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops...

@tedinski
Copy link
Member

General thoughts:

  1. Not sure if we should have AST have a pp, but for now okay no problem. But I think we could probably avoid the dependency on langutil in the final version?
  2. In the end, we probably need tests that do better than compare to string (too brittle?), but obviously I think that's hard to do yet? So ok.

Probably good to merge.

@ericvanwyk
Copy link
Contributor

ericvanwyk commented Jan 11, 2018 via email

@krame505
Copy link
Member Author

  1. Not sure if we should have AST have a pp, but for now okay no problem. But I think we could probably avoid the dependency on langutil in the final version?

Yeah, I suppose those equations could move to aspects in the langutil library.

  1. In the end, we probably need tests that do better than compare to string (too brittle?), but obviously I think that's hard to do yet? So ok.

Agreed, we really need a derivable equality typeclass for this...
I'll go ahead and merge.

@krame505 krame505 merged commit 02480ae into develop Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants