Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract HmmContext struct. #107

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Extract HmmContext struct. #107

merged 1 commit into from
Apr 14, 2024

Conversation

awong-dev
Copy link
Collaborator

Group the variables V, prev, and path together into one struct that provies all the context for the HMM model to function.

@awong-dev awong-dev requested a review from messense April 14, 2024 06:52
Copy link

codspeed-hq bot commented Apr 14, 2024

CodSpeed Performance Report

Merging #107 will not alter performance

Comparing hmm (80bd591) with main (f7e5793)

Summary

✅ 10 untouched benchmarks

@awong-dev
Copy link
Collaborator Author

A simple clean up on the way to #48

Group V, prev, and path together into one struct that provies all the context
for the HMM model to function.
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (f7e5793) to head (80bd591).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   84.74%   84.62%   -0.12%     
==========================================
  Files           8        8              
  Lines        2052     2036      -16     
==========================================
- Hits         1739     1723      -16     
  Misses        313      313              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@messense messense merged commit 46e4273 into main Apr 14, 2024
10 checks passed
@messense messense deleted the hmm branch April 14, 2024 08:33
@awong-dev awong-dev restored the hmm branch April 14, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants