Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compress data at build time #111

Merged
merged 1 commit into from
May 22, 2024

Conversation

fengkx
Copy link
Contributor

@fengkx fengkx commented May 20, 2024

For wasm build, code size matters.
image

Data take up most of space in the wasm build. If it could be compressed at the Rust layer, that would be great. By compressing data wasm build shrink from 7.1 MB to 4.1M

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (b39957e) to head (e9f801c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files           8        8           
  Lines        2036     2036           
=======================================
  Hits         1723     1723           
  Misses        313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #111 will not alter performance

Comparing fengkx:feature/compress-data (e9f801c) with main (b39957e)

Summary

✅ 10 untouched benchmarks

@messense messense merged commit 2736f41 into messense:main May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants