Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DenoRuntime.import is unable to locate modules when used from cli bundled typegate #560

Closed
Yohe-Am opened this issue Jan 20, 2024 · 0 comments · Fixed by #564
Closed

DenoRuntime.import is unable to locate modules when used from cli bundled typegate #560

Yohe-Am opened this issue Jan 20, 2024 · 0 comments · Fixed by #564
Assignees
@Yohe-Am
Labels
bug Something isn't working meta-cli typegate

Comments

@Yohe-Am
Copy link
Contributor

Yohe-Am commented Jan 20, 2024 •
edited by linear bot
Loading

What it says on the tin can. Error is shown here:

image
@Yohe-Am Yohe-Am added bug Something isn't working meta-cli typegate labels Jan 20, 2024
@Yohe-Am Yohe-Am self-assigned this Jan 20, 2024
@zifeo zifeo added the Public label Jan 21, 2024 — with Linear
@zifeo zifeo removed the Public label Jan 21, 2024
@Yohe-Am Yohe-Am mentioned this issue Jan 23, 2024
Merged
3 tasks
@Yohe-Am Yohe-Am linked a pull request Jan 23, 2024 that will close this issue
fix(cli, typegate): explicitly import DenoRuntime.import modules from path #564
Merged
3 tasks
Yohe-Am added a commit that referenced this issue Jan 23, 2024
@Yohe-Am
fix(cli, typegate): explicitly import DenoRuntime.import modules from…
caaabaa 
… path (#564)

When using the dynamic `import` function, if you provide it a raw path
like `/foo/bar/baz` and deno detects the current module's loaded from a
remote host, it'll convert it to a http url. Reasonable behavior but it
turned out to be the cause of #560.

This pr fixes this issue along with:
- Puts contents of `main.ts` in a try/catch block for better error
logging.
- Fixes minor permission bugs with the bundled runtime.

#### Motivation and context

#560 

#### Migration notes

_No changes required_

### Checklist

- [ ] The change come with new or modified tests
- [ ] Hard-to-understand functions have explanatory comments
- [ ] End-user documentation is updated to reflect the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yohe-Am Yohe-Am

Labels
bug Something isn't working meta-cli typegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli, typegate): explicitly import DenoRuntime.import modules from path metatypedev/metatype
2 participants
@zifeo @Yohe-Am