Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop considering log entries with LogLevel.None #2667

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

vmcbaptista
Copy link
Contributor

Fix Issue #2666

Changes

As referenced in #2666 (comment), ApplicationInsightsLogger to ignore LogLevel.None entries.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@ghost
Copy link

ghost commented Aug 25, 2022

CLA assistant check
All CLA requirements met.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
@cijothomas cijothomas enabled auto-merge (squash) August 25, 2022 20:25
@cijothomas cijothomas merged commit f1a9c0d into microsoft:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants