Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-package] add validate_features argument to refit #5331

Merged
merged 1 commit into from
Jul 3, 2022
Merged

[python-package] add validate_features argument to refit #5331

merged 1 commit into from
Jul 3, 2022

Conversation

jmoralez
Copy link
Collaborator

Builds on #4909 adding the validate_features argument to the Booster.refit method.

jameslamb
jameslamb approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

StrikerRUS
StrikerRUS approved these changes Jul 3, 2022
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StrikerRUS
Copy link
Collaborator

What do you think about this predict() call?

LightGBM/python-package/lightgbm/basic.py

Lines 1402 to 1404 in ab9236b

init_score = predictor.predict(data,
raw_score=True,
data_has_header=data_has_header)

Do we need validate_features param there?

@StrikerRUS StrikerRUS merged commit 25e32e9 into master Jul 3, 2022
@StrikerRUS StrikerRUS deleted the validate-features-refit branch July 3, 2022 16:04
@jmoralez
Copy link
Collaborator Author

jmoralez commented Jul 7, 2022

We could try to add it to _set_init_score_by_predictor but it has to go through a lot of places, I'm not sure if it's worth it. WDYT?

@StrikerRUS
Copy link
Collaborator

OK, let's not add it into the Dataset constructor.

@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@jameslamb jameslamb mentioned this pull request Jun 27, 2023
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmoralez @StrikerRUS @jameslamb