Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] always target Windows SDK v10.x when using Visual Studio generators (fixes #6448) #6451

Merged
merged 3 commits into from
May 30, 2024
Merged

[cmake] always target Windows SDK v10.x when using Visual Studio generators (fixes #6448) #6451

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f812315
[cmake] always target Windows SDK v10.x when using Visual Studio gene…
jameslamb May 9, 2024
6abbd2c
formatting
jameslamb May 9, 2024
8d8fe19
Merge branch 'master' into fix/windows-sdk-version
jameslamb May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ option(__INTEGRATE_OPENCL "Set to ON if building LightGBM with the OpenCL ICD Lo

cmake_minimum_required(VERSION 3.18)

# If using Visual Studio generators, always target v10.x of the Windows SDK.
# Doing this avoids lookups that could fall back to very old versions, e.g. by finding
# outdated registry entries.
# ref: https://cmake.org/cmake/help/latest/variable/CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION.html
if(CMAKE_GENERATOR MATCHES "Visual Studio")
set(CMAKE_SYSTEM_VERSION 10.0 CACHE INTERNAL "target Windows SDK version" FORCE)
endif()

project(lightgbm LANGUAGES C CXX)

if(BUILD_CPP_TEST)
Expand Down
Loading