[ci] [R-package] run 'R CMD check' as a foreground task #6508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez and
borchero
as code owners
jmoralez
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6498
4 years ago, this project was running a lot of its R-package testing on Travis CI. We experienced an issue where
R CMD checkwould run for too long without emitting a new log line, and as a result Travis killed jobs.A workaround was introduced in #3092 ... running
R CMD checkas a background task and polling for the status of it's process ID.I strongly suspect this is no longer necessary:
This proposes removing that workaround, to hopefully make it a bit easier to understand the CI setup. It also fixes some
shellcheckerrors, mentioned in #6501 (comment)How I tested this
Checked a few of the logs to be sure
R CMD checkis really being run and is succeeding. Looks good to me!https://github.com/microsoft/LightGBM/actions/runs/9788164564/job/27025779285?pr=6508#step:9:2015
If it wasn't safe to remove this, we'd see jobs outright fail. I'm pretty confident this is safe to do.