Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change _MSVC_STL_UPDATE to June 2023 #3742

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Change _MSVC_STL_UPDATE to June 2023 #3742

merged 1 commit into from
Jun 15, 2023

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented May 31, 2023

Closes: #3741

@tungbq tungbq requested a review from a team as a code owner May 31, 2023 09:10
fsb4000
fsb4000 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@fsb4000 fsb4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your patch is good!
The test suite failed for some unknown reason.
I pinged the Microsoft developers.
They will rerun the pipeline later.
You don't need to do anything.

@fsb4000

This comment was marked as off-topic.

Sign in to view
@CaseyCarter CaseyCarter added the enhancement Something can be improved label May 31, 2023
@CaseyCarter
Copy link
Member

Looks great! I kicked the stalled test so it should run to completion now.

FYI, our process is to merge things in batches, so once a second maintainer approves this will sit for a few days before being merged as part of a batch. Congratulations on your first STL contribution!

@tungbq
Copy link
Contributor Author

tungbq commented Jun 2, 2023

Thank you all for reviewing and collaboration!

@StephanTLavavej StephanTLavavej self-assigned this Jun 14, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2234fe2 into microsoft:main Jun 15, 2023
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 🚀 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to June 2023
4 participants
@tungbq @fsb4000 @CaseyCarter @StephanTLavavej