<format>: Move the major part of visit_format_arg into a member function of basic_format_arg
#3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of `basic_format_arg` Also fix a small bug on an `int` rvalue.
barcharcraz
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
This looks like a good simplification, normally I wouldn't love factoring out _Visit like this given it's only used in one place, but given we're getting ride of the friend declaration here it doesn't seem like it's increasing the amount of indirection you need to follow to understand the code.
StephanTLavavej
approved these changes
Jun 20, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this refactoring and small bugfix! 🐞 🛠️ 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a small bug on visiting
0. As the visitor always visits a cv-unqualifiedbasic_format_arglvalue, it's incorrect to use_STD forward<_Visitor>(_Vis)(0)which takes anintprvalue and can result in non-conforming ill-formedness.IMO this PR will make it simpler to implement WG21-P2637R3. Unfortunately, we're perhaps unable to implement that paper at this moment.