Strengthen exception specification for some facet base types #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make `messages_base` implicitly default constructible. Also add some "TRANSITION, ABI" comments for non-Standard inheritance.
StephanTLavavej
approved these changes
Jul 11, 2023
|
Thanks! This appears to be correct and safe (notable given my extreme caution regarding locale changes), and I agree with the TRANSITION, ABI comments - good catch! |
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Jul 13, 2023
🦾 🦿 🏋️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make
messages_baseimplicitly default constructible, which seems to be implied by the standard wording.Also add some "TRANSITION, ABI" comments because it seems that these base types shouldn't be derived from
locale::facet.