Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _MSVC_STL_UPDATE to October 2023 #4062

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Update _MSVC_STL_UPDATE to October 2023 #4062

merged 1 commit into from
Oct 4, 2023

Conversation

Ananyasingh2002
Copy link
Contributor

@Ananyasingh2002 Ananyasingh2002 commented Sep 30, 2023 •
edited
Loading

Fixes #4061

@Ananyasingh2002 Ananyasingh2002 requested a review from a team as a code owner September 30, 2023 11:51
@fsb4000
Copy link
Contributor

fsb4000 commented Sep 30, 2023

Could you change title of your Pull Request from "fixed" to "Update _MSVC_STL_UPDATE to October 2023"

And your description to "Fixes #4061" (to activate GitHub's close/fix/resolve syntax. )

?

The code change is correct.

@Ananyasingh2002 Ananyasingh2002 changed the title fixed Update _MSVC_STL_UPDATE to October 2023 Sep 30, 2023
@Ananyasingh2002
Copy link
Contributor Author

Done

@Ananyasingh2002
Copy link
Contributor Author

Aren't you going to merge it?

@sam20908
Copy link
Contributor

PRs are usually merged in batches.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 1, 2023
@StephanTLavavej
Copy link
Member

Thanks! Yes, as @sam20908 mentioned, we merge PRs in batches, so I'll merge yours during the upcoming week. (This is because we do virtually all work in this public GitHub repo, but the MSVC toolset is still built in a Microsoft-internal repo, so we mirror PRs to keep the repos binary-identical at all times. This semi-manual process is slightly time-consuming so we batch up PRs and usually merge them weekly.)

@CaseyCarter

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Oct 3, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 04742ec into microsoft:main Oct 4, 2023
71 checks passed
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro and congratulations on your first microsoft/STL commit! 🎉 😸 🚀

This value will ship in VS 2022 17.9 Preview 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to October 2023
5 participants
@Ananyasingh2002 @fsb4000 @sam20908 @StephanTLavavej @CaseyCarter