Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-4001 iota_view should provide empty #4193

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Implement LWG-4001 iota_view should provide empty #4193

merged 2 commits into from
Nov 17, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4159.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner November 14, 2023 15:43
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Nov 14, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 14, 2023
StephanTLavavej
StephanTLavavej reviewed Nov 14, 2023
View reviewed changes
stl/inc/ranges Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_iota/test.cpp Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Nov 14, 2023
@StephanTLavavej
Copy link
Member

Thanks! I pushed minor changes, and I think this needs only one maintainer approval.

@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 62f3a38 into microsoft:main Nov 17, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

🧮 👓 0️⃣

@frederick-vs-ja frederick-vs-ja deleted the lwg-4001 branch November 17, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-4001 iota_view should provide empty
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter