Make ~mutex trivial
#4390
Merged
Make ~mutex trivial
#4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By simply removing `~_Mutex_base`. This destructor has been only a debug check since microsoftGH-3770. Losing the debug check is a small price to pay to elide the destructor call, doubly so for static storage duration mutexes that now won't need dynamic initializers to register with `at_exit`. `_Mtx_destroy` and `_Mtx_destroy_in_situ` are only called by APIs preserved for binary compatibility, so mark them as also "preserved for binary compatibility".
CaseyCarter
commented
Feb 13, 2024
| @@ -45,10 +45,6 @@ public: | |||
| } | |||
| #endif // ^^^ !defined(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) ^^^ | |||
|
|
|||
| ~_Mutex_base() noexcept { | |||
| _Mtx_destroy_in_situ(_Mymtx()); | |||
There was a problem hiding this comment.
I could be convinced to retain this debug check for ~recursive_mutex, which feels less performance-sensitive to me. Thoughts, comments?
There was a problem hiding this comment.
I'm fine with dropping it.
AlexGuteniev
approved these changes
Feb 13, 2024
StephanTLavavej
approved these changes
Feb 14, 2024
| @@ -45,10 +45,6 @@ public: | |||
| } | |||
| #endif // ^^^ !defined(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) ^^^ | |||
|
|
|||
| ~_Mutex_base() noexcept { | |||
| _Mtx_destroy_in_situ(_Mymtx()); | |||
There was a problem hiding this comment.
I'm fine with dropping it.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this trivial PR with nontrivial impact! 😹 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By simply removing
~_Mutex_base. This destructor has been only a debug check since GH-3770. Losing the debug check is a small price to pay to elide the destructor call, doubly so for static storage duration mutexes that now won't need dynamic initializers to register withat_exit._Mtx_destroyand_Mtx_destroy_in_situare only called by APIs preserved for binary compatibility, so mark them as also "preserved for binary compatibility".