Avoid truncation warnings for contiguous iterators with unusual difference types #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
tests/std/tests/GH_003663_cast_contiguous_iterator_to_correct_type/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_003663_cast_contiguous_iterator_to_correct_type/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_003663_cast_contiguous_iterator_to_correct_type/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Aug 22, 2024
|
Thanks, this is awesome! 😻 I pushed commits for minor nitpicks in the test. |
StephanTLavavej
changed the title
_CtgIt2 and _OutCtgIt
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing these truncation warnings and congratulations on your second microsoft/STL commit! 🚀 🐈 🐈⬛ This is expected to ship in VS 2022 17.12 Preview 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3663
It's my second time contributing STL.
I would be appreciated if you could review my code and testcase.
Any suggestions are welcome.