Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llvm-project #4910

Merged
merged 14 commits into from
Aug 25, 2024
Merged

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Aug 24, 2024

@StephanTLavavej StephanTLavavej added the test Related to test code label Aug 24, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 24, 2024 18:20
@StephanTLavavej
Copy link
Member Author

/azp run STL-ASan-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Copy link
Member Author

Light is green, trap is clean (eventually): https://dev.azure.com/vclibs/STL/_build/results?buildId=17368&view=results

Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the new commit is on llvm-project's main, everything looks good. (Guess I should use this for the 19.1.0-rc3 validation I was planning to run today.)

@CaseyCarter
Copy link
Member

Light is green, trap is clean (eventually): https://dev.azure.com/vclibs/STL/_build/results?buildId=17368&view=results

Either we've been extremely lucky, or the sporadic x86 ASan failures have become less frequent since updating our toolset to 17.12p1.

@cpplearner
Copy link
Contributor

A bunch of libc++ tests have been refactored to remove flakyness. They can probably be removed from expected_results.txt.

@CaseyCarter
Copy link
Member

A bunch of libc++ tests have been refactored to remove flakyness. They can probably be removed from expected_results.txt.

I see a lot of removal of ALLOW_RETRIES, this looks like a righteous change. This PR is a rush job to meet an internal deadline, I'd rather reenable this test coverage in a followup PR.

@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member Author

I reported llvm/llvm-project#105966 and pushed an additional commit.

@StephanTLavavej StephanTLavavej merged commit 1a84ba0 into microsoft:main Aug 25, 2024
39 checks passed
@StephanTLavavej StephanTLavavej deleted the update-llvm branch August 25, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants