Begin removing EDG workaround from ranges::to tests
#4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSO-2208356 has been fixed internally. Disable the workaround internally, and mark the workaround for cleanup when VS 17.12p3 releases. This mirrors MSVC-PR-577053.
CaseyCarter
commented
Sep 10, 2024
StephanTLavavej
approved these changes
Sep 10, 2024
StephanTLavavej
changed the title
ranges::to tests
|
Citing the MSVC-PR being mirrored in the PR description is great (yay autolink references), but it makes for an exceptionally opaque PR title / commit subject. When scanning history, it's much more useful to have brief descriptions of what changed. I've changed the title and added a bit more clarity than before (mentioning that this affects (Yes I am a very picky kitty 🐈) |
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Sep 10, 2024
Let's make these more consistent with the messages for `find_package(Python)` and the assembler. If nothing else, showing the path to the found clang-format may help folks who are finding the wrong version. Remove extraneous `element_type` from `ContiguousIterator` And while we're here, use `value_type` and `difference_type` where appropriate so we can easily see which `int` is which. Remove unused include from `P2163R3_invoke_r` This test doesn't need `is_permissive.hpp` after microsoft#4914. Simplify `construct_at` constraint Investigate a couple of libc++ failures Add some missing `#endif` comments These were incorrectly removed by microsoft#4944.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Sep 10, 2024
* Pretty clang-format find/version check messages Let's make these more consistent with the messages for `find_package(Python)` and the assembler. If nothing else, showing the path to the found clang-format may help folks who are finding the wrong version. * Remove extraneous `element_type` from `ContiguousIterator` And while we're here, use `value_type` and `difference_type` where appropriate so we can easily see which `int` is which. * Remove unused include from `P2163R3_invoke_r` This test doesn't need `is_permissive.hpp` after microsoft#4914. * Simplify `construct_at` constraint * Investigate a couple of libc++ failures * Add some missing `#endif` comments These were incorrectly removed by microsoft#4944.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Sep 10, 2024
* Pretty clang-format find/version check messages: Let's make these more consistent with the messages for `find_package(Python)` and the assembler. Showing the path may help folks with problems. * Remove extraneous `element_type` from `ContiguousIterator`: While we're here, let's use `value_type` and `difference_type` where appropriate so we can see which `int` is which. * Remove unused include from `P2163R3_invoke_r`: This test doesn't need `is_permissive.hpp` after microsoft#4914. * Simplify `construct_at` constraint * Investigate a couple of libc++ failures * Add some missing `#endif` comments: These were incorrectly removed by microsoft#4944.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Sep 10, 2024
These were incorrectly removed by microsoft#4944.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Sep 10, 2024
These were incorrectly removed by microsoft#4944.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSO-2208356 has been fixed internally. Disable the workaround internally, and mark the workaround for cleanup when VS 17.12p3 releases.
This mirrors MSVC-PR-577053.