Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional's secret constructor private #4961

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

CaseyCarter
Copy link
Member

This avoids interfering with pathological initializations like the one in std/utilities/optional/optional.object/optional.object.ctor/gh_101960_internal_ctor.compile.pass.cpp.

This avoids interfering with pathological initializations like the one in `std/utilities/optional/optional.object/optional.object.ctor/gh_101960_internal_ctor.compile.pass.cpp`.
@CaseyCarter CaseyCarter added the bug Something isn't working label Sep 17, 2024
@CaseyCarter CaseyCarter requested a review from a team as a code owner September 17, 2024 17:36
@StephanTLavavej StephanTLavavej self-assigned this Sep 19, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7b154c5 into microsoft:main Sep 19, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Too many secrets! 🔭 🤫 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants