Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use steady_clock in timed mutex test #4973

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

AlexGuteniev
Copy link
Contributor

Can I tell you only one solution to this problem? Ditch the second clock!

Fixes #1472

With the series of PRs ended with #4755 we should be fine with this change.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner September 21, 2024 08:09
@CaseyCarter CaseyCarter added the bug Something isn't working label Sep 21, 2024
@StephanTLavavej StephanTLavavej added test Related to test code and removed bug Something isn't working labels Sep 21, 2024
@StephanTLavavej
Copy link
Member

Re-labeling as "test" because this isn't a product code bug.

@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2024
@StephanTLavavej
Copy link
Member

Awesome - thanks for digging this up and fixing it! 😻

@StephanTLavavej StephanTLavavej removed their assignment Sep 23, 2024
@StephanTLavavej StephanTLavavej self-assigned this Sep 27, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ad383d1 into microsoft:main Sep 28, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

⏱️ 🔒 🛠️

@AlexGuteniev AlexGuteniev deleted the observing-clock branch September 28, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

VSO_0226079_mutex is sporadically failing
3 participants