Simplify object types when distributing index over them #60021

Andarist · 2024-09-21T09:31:35Z

…ned`

Andarist · 2024-09-21T09:36:59Z

src/compiler/checker.ts

@@ -18997,7 +18997,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
        // (T | U)[K] -> T[K] & U[K] (writing)
        // (T & U)[K] -> T[K] & U[K]
        if (objectType.flags & TypeFlags.Union || objectType.flags & TypeFlags.Intersection && !shouldDeferIndexType(objectType)) {
-            const types = map((objectType as UnionOrIntersectionType).types, t => getSimplifiedType(getIndexedAccessType(t, indexType), writing));
+            const types = map((objectType as UnionOrIntersectionType).types, t => getSimplifiedType(getIndexedAccessType(getSimplifiedType(t, writing), indexType), writing));


It's important to simplify the t (a constituent of the objectType) here "eagerly". At this stage getIndexedAccessType has a chance to return unknownType (thus effectively eliminating this constituent from the overall simplified indexed access type on an intersection, since T & unknown is T).

Without it, the compiler comes back to getSimplifiedIndexedAccessType with the non-simplified indexed access. It simplifies the object type there, but it also decides there is nothing to simplify further so it returns the original non-simplified type. That leads to a relationship error.

jakebailey · 2024-09-21T16:11:54Z

@typescript-bot test it

typescript-bot · 2024-09-21T16:11:58Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-21T16:33:32Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-21T16:40:27Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60021/merge:

Everything looks good!

typescript-bot · 2024-09-21T16:51:11Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,601k (± 0.97%)}	_{192,981k (± 0.74%)}	_~	_192,390k	_195,879k	_{p=0.810 n=6}
_{Parse Time}	_{1.30s (± 0.79%)}	_{1.30s (± 0.93%)}	_~	_1.29s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.58s (± 0.41%)}	_{9.56s (± 0.47%)}	_~	_9.50s	_9.63s	_{p=0.225 n=6}
_{Emit Time}	_{2.70s (± 1.73%)}	_{2.72s (± 0.95%)}	_~	_2.68s	_2.75s	_{p=1.000 n=6}
_{Total Time}	_{14.29s (± 0.46%)}	_{14.28s (± 0.31%)}	_~	_14.20s	_14.32s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,743k (± 0.00%)}	_{1,222,748k (± 0.00%)}	_~	_1,222,686k	_1,222,810k	_{p=0.936 n=6}
_{Parse Time}	_{6.63s (± 0.34%)}	_{6.65s (± 0.63%)}	_~	_6.57s	_6.68s	_{p=0.090 n=6}
_{Bind Time}	_{1.86s (± 0.40%)}	_{1.86s (± 0.40%)}	_~	_1.85s	_1.87s	_{p=0.487 n=6}
_{Check Time}	_{31.25s (± 0.50%)}	_{31.24s (± 0.43%)}	_~	_31.11s	_31.46s	_{p=0.936 n=6}
_{Emit Time}	_{15.02s (± 0.37%)}	_{15.00s (± 0.46%)}	_~	_14.90s	_15.08s	_{p=0.689 n=6}
_{Total Time}	_{54.77s (± 0.29%)}	_{54.75s (± 0.32%)}	_~	_54.46s	_54.94s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,472	_2,529,472	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,018	_936,018	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,766k (± 0.00%)}	_{2,364,771k (± 0.00%)}	_~	_2,364,737k	_2,364,843k	_{p=0.873 n=6}
_{Parse Time}	_{9.41s (± 0.17%)}	_{9.43s (± 0.23%)}	_~	_9.40s	_9.46s	_{p=0.060 n=6}
_{Bind Time}	_{2.18s (± 0.29%)}	_{2.17s (± 0.24%)}	_~	_2.17s	_2.18s	_{p=0.091 n=6}
_{Check Time}	_{72.83s (± 0.39%)}	_{72.99s (± 0.48%)}	_~	_72.73s	_73.60s	_{p=0.521 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.28s (± 2.95%)}	_~	_0.27s	_0.29s	_{p=0.206 n=6}
_{Total Time}	_{84.69s (± 0.33%)}	_{84.86s (± 0.41%)}	_~	_84.59s	_85.47s	_{p=0.470 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,550	_1,246,550	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,444	_264,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,398,967k (± 0.04%)}	_{2,398,824k (± 0.02%)}	_~	_2,398,301k	_2,399,394k	_{p=1.000 n=6}
_{Parse Time}	_{5.09s (± 0.45%)}	_{5.12s (± 0.31%)}	_{+0.03s (+ 0.59%)}	_5.09s	_5.13s	_{p=0.036 n=6}
_{Bind Time}	_{1.91s (± 0.91%)}	_{1.92s (± 0.47%)}	_~	_1.91s	_1.93s	_{p=0.459 n=6}
_{Check Time}	_{34.88s (± 0.44%)}	_{34.90s (± 0.71%)}	_~	_34.62s	_35.31s	_{p=1.000 n=6}
_{Emit Time}	_{3.09s (± 5.89%)}	_{3.08s (± 5.50%)}	_~	_2.95s	_3.41s	_{p=0.873 n=6}
_{Total Time}	_{44.98s (± 0.43%)}	_{45.03s (± 0.40%)}	_~	_44.73s	_45.28s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,246,550	_1,246,550	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,444	_264,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,473,990k (± 0.05%)}	_{2,498,948k (± 2.50%)}	_~	_2,472,829k	_2,626,800k	_{p=0.936 n=6}
_{Parse Time}	_{6.33s (± 0.63%)}	_{6.39s (± 0.73%)}	_~	_6.34s	_6.47s	_{p=0.066 n=6}
_{Bind Time}	_{2.05s (± 0.85%)}	_{2.06s (± 0.97%)}	_~	_2.03s	_2.09s	_{p=0.466 n=6}
_{Check Time}	_{41.46s (± 0.47%)}	_{41.65s (± 0.59%)}	_~	_41.26s	_41.85s	_{p=0.128 n=6}
_{Emit Time}	_{3.56s (± 2.92%)}	_{3.56s (± 1.22%)}	_~	_3.51s	_3.61s	_{p=0.688 n=6}
_{Total Time}	_{53.42s (± 0.40%)}	_{53.66s (± 0.52%)}	_~	_53.24s	_53.94s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,902	_259,902	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,141	_106,141	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{435,643k (± 0.02%)}	_{435,563k (± 0.01%)}	_~	_435,502k	_435,633k	_{p=0.230 n=6}
_{Parse Time}	_{3.41s (± 1.17%)}	_{3.42s (± 0.48%)}	_~	_3.41s	_3.45s	_{p=0.808 n=6}
_{Bind Time}	_{1.28s (± 1.45%)}	_1.30s	_{+0.02s (+ 1.30%)}	_~	_~	_{p=0.028 n=6}
_{Check Time}	_{18.12s (± 0.40%)}	_{18.15s (± 0.28%)}	_~	_18.10s	_18.21s	_{p=0.469 n=6}
_{Emit Time}	_{1.52s (± 2.66%)}	_{1.52s (± 1.78%)}	_~	_1.48s	_1.56s	_{p=1.000 n=6}
_{Total Time}	_{24.34s (± 0.19%)}	_{24.39s (± 0.23%)}	_~	_24.33s	_24.47s	_{p=0.195 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,195k (± 0.02%)}	_{370,233k (± 0.02%)}	_~	_370,150k	_370,332k	_{p=0.575 n=6}
_{Parse Time}	_{2.74s (± 0.48%)}	_{2.76s (± 1.11%)}	_~	_2.71s	_2.79s	_{p=0.360 n=6}
_{Bind Time}	_{1.55s (± 0.88%)}	_{1.56s (± 0.48%)}	_~	_1.55s	_1.57s	_{p=0.149 n=6}
_{Check Time}	_{15.71s (± 0.32%)}	_{15.72s (± 0.33%)}	_~	_15.62s	_15.76s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.99s (± 0.29%)}	_{20.04s (± 0.24%)}	_~	_19.98s	_20.10s	_{p=0.199 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,094,261	_3,094,261	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,066,604	_1,066,604	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,191,745k (± 0.00%)}	_{3,191,733k (± 0.00%)}	_~	_3,191,686k	_3,191,775k	_{p=0.936 n=6}
_{Parse Time}	_{13.99s (± 0.25%)}	_{13.99s (± 0.32%)}	_~	_13.92s	_14.04s	_{p=0.936 n=6}
_{Bind Time}	_{4.36s (± 0.48%)}	_{4.36s (± 0.24%)}	_~	_4.35s	_4.38s	_{p=0.570 n=6}
_{Check Time}	_{82.04s (± 0.69%)}	_{82.10s (± 0.25%)}	_~	_81.88s	_82.45s	_{p=0.575 n=6}
_{Emit Time}	_{22.39s (± 0.31%)}	_{22.39s (± 0.44%)}	_~	_22.31s	_22.57s	_{p=0.687 n=6}
_{Total Time}	_{122.78s (± 0.47%)}	_{122.84s (± 0.17%)}	_~	_122.54s	_123.05s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,196	_277,196	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,950	_112,950	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,903k (± 0.02%)}	_{426,967k (± 0.02%)}	_~	_426,879k	_427,049k	_{p=0.173 n=6}
_{Parse Time}	_{3.95s (± 0.32%)}	_{3.95s (± 0.30%)}	_~	_3.93s	_3.96s	_{p=0.801 n=6}
_{Bind Time}	_{1.73s (± 1.24%)}	_{1.72s (± 1.20%)}	_~	_1.69s	_1.75s	_{p=1.000 n=6}
_{Check Time}	_{17.61s (± 0.52%)}	_{17.66s (± 0.59%)}	_~	_17.55s	_17.80s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.29s (± 0.35%)}	_{23.34s (± 0.50%)}	_~	_23.20s	_23.49s	_{p=0.575 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,943	_539,943	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,263	_181,263	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,329k (± 0.02%)}	_{483,310k (± 0.01%)}	_~	_483,241k	_483,361k	_{p=0.810 n=6}
_{Parse Time}	_{4.03s (± 0.36%)}	_{4.02s (± 0.40%)}	_~	_4.00s	_4.04s	_{p=0.324 n=6}
_{Bind Time}	_{1.45s (± 1.07%)}	_{1.44s (± 0.81%)}	_~	_1.43s	_1.46s	_{p=0.249 n=6}
_{Check Time}	_{22.69s (± 0.22%)}	_{22.66s (± 0.20%)}	_~	_22.61s	_22.73s	_{p=0.375 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.17s (± 0.17%)}	_{28.11s (± 0.20%)}	_~	_28.04s	_28.19s	_{p=0.108 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-21T17:52:43Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60021/merge:

Everything looks good!

Andarist added 2 commits September 21, 2024 11:29

Substitute some indexed mapped types in `getIndexedAccessTypeOrUndefi…

df805a0

…ned`

Simplify object types when distributing index over them

2ae190f

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 21, 2024

Andarist commented Sep 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify object types when distributing index over them #60021

Simplify object types when distributing index over them #60021

Andarist commented Sep 21, 2024

Andarist Sep 21, 2024 •

edited

Loading

jakebailey commented Sep 21, 2024

typescript-bot commented Sep 21, 2024 •

edited

Loading

typescript-bot commented Sep 21, 2024

typescript-bot commented Sep 21, 2024

typescript-bot commented Sep 21, 2024

tsc

typescript-bot commented Sep 21, 2024

Simplify object types when distributing index over them #60021

Are you sure you want to change the base?

Simplify object types when distributing index over them #60021

Conversation

Andarist commented Sep 21, 2024

Andarist Sep 21, 2024 • edited Loading

Choose a reason for hiding this comment

jakebailey commented Sep 21, 2024

typescript-bot commented Sep 21, 2024 • edited Loading

typescript-bot commented Sep 21, 2024

typescript-bot commented Sep 21, 2024

typescript-bot commented Sep 21, 2024

tsc

typescript-bot commented Sep 21, 2024

Andarist Sep 21, 2024 •

edited

Loading

typescript-bot commented Sep 21, 2024 •

edited

Loading