Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit tagnames so types can be forward declared #1052

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add explicit tagnames so types can be forward declared #1052

merged 1 commit into from
Sep 22, 2022

Conversation

stephenatwork
Copy link
Member

See issue #1051

maxgolov
maxgolov approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@maxgolov maxgolov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve as author of this code. Looks consistent, and should work even with older compilers.

I'd like you to wait for the current maintainer's approval @lalitb

lalitb
lalitb approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lalitb
Copy link
Contributor

lalitb commented Sep 22, 2022

@stephenatwork - This PR looks good to merge. Can you please merge it,

@maxgolov maxgolov merged commit c56d09c into microsoft:main Sep 22, 2022
@maxgolov
Copy link
Contributor

We're working together with Stephen on this feature. I took the liberty to merge it :)

@lalitb lalitb mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@maxgolov maxgolov maxgolov approved these changes

@kindbe kindbe Awaiting requested review from kindbe

@mkoscumb mkoscumb Awaiting requested review from mkoscumb

@reyang reyang Awaiting requested review from reyang

@bliptec bliptec Awaiting requested review from bliptec

@sid-dahiya sid-dahiya Awaiting requested review from sid-dahiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenatwork @lalitb @maxgolov