[Fix: 1081] upgrade googletest to v1.12.1 #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
requested review from
kindbe,
maxgolov,
mkoscumb,
reyang,
bliptec and
sid-dahiya
as code owners
lalitb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1081
The
ubuntu-latestvirtual environment for GitHub is upgraded toubuntu-22.04, which bringsg++-11.0as default compiler. And the version of googletest using by 1ds-sdk (v1.11.1) doesn't build successfully with new compiler. Refer - google/googletest#3797 and google/googletest#3219. The fix is to upgrade the googletest to latest versionv1.12.1.