[OneDS] Integrate Event Tracking Mechanism in OneDS #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivpratap1992
requested review from
kindbe,
maxgolov,
mkoscumb,
reyang,
bliptec,
lalitb and
sid-dahiya
as code owners
shivpratap1992
changed the title
lalitb
reviewed
Mar 15, 2023
lalitb
reviewed
Mar 16, 2023
lalitb
reviewed
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently there is no way to track what event sent from application like MIP SDK to 1DS are actually being emitted out.
Fix:
Application like MIP SDK will populate tracking ID in CV while calling evt_log() method under event properties argument in MIP SDK side and write event id in MIP log before sending. Eventually, we will add this CV (tracking ID) in http request header while calling MIP http delegate in 1DS.
Design Doc: https://microsoft.sharepoint.com/:w:/t/ceip/EVeouFG5ZWBItrZbmppxOxgBSP9dhzDa3vFhVjXJmefw1w
Flight/Setting:
Entire code is under a defined macro, until this HAVE_MAT_EVT_TRACEID macro is not defined, new code won't take effect.