Add Properties class for Swift wrappers #1138
Conversation
absaroj
requested review from
kindbe,
maxgolov,
mkoscumb,
reyang,
bliptec,
lalitb,
sid-dahiya and
ThomsonTan
as code owners
…ith other required files
absaroj
changed the title
wrappers/swift/CMakeLists.txt
Outdated
| @@ -0,0 +1,25 @@ | |||
| CMAKE_MINIMUM_REQUIRED(VERSION 3.16) | |||
There was a problem hiding this comment.
This version is higher than root level and Obj-C wrapper level versions, why?
There was a problem hiding this comment.
This was done when swift generators were failing to be generated and there was one suggestion to change it to this version.
But i think with xcode generators, this is not required. i can change it back to similar to obj-c.
There is below warning of deprecation though:
_CMake Deprecation Warning at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions._
|
|
||
| let props = EventProperties(name:"TestEvent") | ||
| props.setProperty("PropName", withValue: ["Type":"SwiftWrappers"]) | ||
| props.setProperty("PropWithPII", withInt64Value: Int64(30), withPiiKind: ODWPiiKind.distinguishedName) |
There was a problem hiding this comment.
Are consumers going to use Obj-C constants/enums, or are you going to setup new ones for Swift?
There was a problem hiding this comment.
I am intending to let consumers use the obj-c enums instead of creating new ones in swift
| - value: A Date that contains the property value. | ||
| - piiKind: The kind of Personal Identifieable Information (PII), one from the ::ODWPiiKind enum values. | ||
| */ | ||
| public func setProperty(_ name: String, withDateValue value: Date, withPiiKind piiKind: ODWPiiKind) { |
There was a problem hiding this comment.
As we are using the obj-c definitions ( e.g. ODWPiiKind ) in swift code, are there any interoperability issues between obj-c and swift that the app developer be aware of - E.g. interoperability across Swift compiler version and Obj-c runtime version etc. And as I understand, we can't avoid obj-c usage eventually, as the C++ code can't be directly called from swift ?
There was a problem hiding this comment.
Thanks for the point.
Yes, we have to access c++ via objc from swift.
Though I haven't noticed any interoperability issues while building and running the code. However there are minor changes when it comes to using the enum declared in objc from swift, such as Enum prefix name is removed while using. But since they are minor, i thought of keep using the objc enums rather than creating their duplicate in swift.
also, i have create a task to investigate more about the different compiler and version compatibility between swift-objc and update the source files accordingly.
| set(PLATFORM_FILES main.swift SDWEventProperties.swift) | ||
| set(CMAKE_Swift_FLAGS "${CMAKE_Swift_FLAGS} -import-objc-header Swift_Wrapper-Bridging-Header.h") | ||
| add_executable(swift_sample ${PLATFORM_FILES}) | ||
| target_link_libraries(swift_sample) |
There was a problem hiding this comment.
This doesn't add any extra property, is it necessary?
There was a problem hiding this comment.
are you asking about the last line? it i used to create the final exe by linking all the libs.
Swift Wrappers:
Adding Swift wrappers to 1DSSDK. Since C++ code can only be accessed from Swift via Obj-C or C, I am taking Obj-C with bridging header.
Wrapping ODWEventProperties.mm class for Swift. Contains other supporting files: