Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert time from eventPropertiesto ticks #1165

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Convert time from eventPropertiesto ticks #1165

merged 7 commits into from
Aug 3, 2023

Conversation

ThomsonTan
Copy link
Contributor

Fixes #1108

lalitb
lalitb approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix,

@lalitb lalitb merged commit c7bb501 into main Aug 3, 2023
20 checks passed
@lalitb lalitb deleted the FixTime branch August 3, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@kindbe kindbe Awaiting requested review from kindbe

@maxgolov maxgolov Awaiting requested review from maxgolov

@mkoscumb mkoscumb Awaiting requested review from mkoscumb

@reyang reyang Awaiting requested review from reyang

@bliptec bliptec Awaiting requested review from bliptec

@sid-dahiya sid-dahiya Awaiting requested review from sid-dahiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] EventInfo.Time is set to year 0001 despite TimeStamp being set correctly on eventproperties
2 participants
@ThomsonTan @lalitb