Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated CURL API usage. #1238

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix deprecated CURL API usage. #1238

merged 2 commits into from
Feb 2, 2024

Conversation

utoni
Copy link
Contributor

@utoni utoni commented Jan 26, 2024 

lib/./http/HttpClient_Curl.hpp: In member function ‘long int Microsoft::Applications::Events::CurlHttpOperation::Send()’:
lib/./http/HttpClient_Curl.hpp:211:39: error: ‘CURLINFO_LASTSOCKET’ is deprecated: since 7.45.0. Use CURLINFO_ACTIVESOCKET [-Werror=deprecated-declarations]
  211 |         res = curl_easy_getinfo(curl, CURLINFO_LASTSOCKET, &sockextr);

@utoni utoni requested a review from a team as a code owner January 26, 2024 15:32
lalitb
lalitb approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with suggestion :)

@utoni
Fix deprecated CURL API usage.
6f7ab1c 
```
lib/./http/HttpClient_Curl.hpp: In member function ‘long int Microsoft::Applications::Events::CurlHttpOperation::Send()’:
lib/./http/HttpClient_Curl.hpp:211:39: error: ‘CURLINFO_LASTSOCKET’ is deprecated: since 7.45.0. Use CURLINFO_ACTIVESOCKET [-Werror=deprecated-declarations]
  211 |         res = curl_easy_getinfo(curl, CURLINFO_LASTSOCKET, &sockextr);
```

Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
@utoni
Copy link
Contributor Author

utoni commented Jan 27, 2024

Fixed for the sake of simplicity.

@lalitb lalitb merged commit e8dd205 into microsoft:main Feb 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

@eduardo-camacho eduardo-camacho eduardo-camacho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@utoni @ThomsonTan @lalitb @eduardo-camacho