Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nlohmann/json to 3.11.3 #1262

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Upgrade nlohmann/json to 3.11.3 #1262

merged 3 commits into from
Apr 15, 2024

Conversation

shae-brown
Copy link
Contributor

Library hasn't been upgraded for a while and new versions include crash fixes

@shae-brown shae-brown marked this pull request as ready for review April 12, 2024 00:01
@shae-brown shae-brown requested a review from a team as a code owner April 12, 2024 00:01
@lalitb
Copy link
Contributor

lalitb commented Apr 15, 2024

@shae-brown Looks good. Can you add the below changes to the header before merge:

a9c2234

Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@shae-brown shae-brown merged commit 2db335c into main Apr 15, 2024
20 checks passed
@shae-brown shae-brown deleted the shbrow/upgrade-nnolman branch April 15, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants