Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set locale and country code only when supported by Apple OS Version #929

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

eduardo-camacho
Copy link
Contributor

languageCode and contryCode are not supported for Mac 10.11 or earlier versions as per Apple documentation: https://developer.apple.com/documentation/foundation/nslocale/1643026-languagecode?language=objc

Added branching to only call APIs when supported

Copy link
Contributor

@sid-dahiya sid-dahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eduardo-camacho eduardo-camacho merged commit a8c90ab into main Sep 16, 2021
@eduardo-camacho eduardo-camacho deleted the eduardo-camacho/feature/Locale1010 branch September 16, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants