Callout focusWindow, blurWindow API with MacOS native implementation #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sWindow and blurWindow on the Callout (replacing focus and blur of View)
…codegenNativeCommands to each NativeComponent file
|
Hey @Saadnajmi, where is the source of truth for apple native code? |
PPatBoyd
changed the title
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
reviewed
Sep 27, 2024
Saadnajmi
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Adds native functions
focusWindowandblurWindowto Callout for proper foreground/focused window management.On Apple the corresponding concept is the
Key Window.On Win32 the corresponding concept is the
Active/Activated WindowVerification
Manual validation with extensions to the Callout test page.
Win32 not actually available with this API as the current behavior of the Win32 View
focusAPI is to forceful make its window take activation, which isn't the appropriate action for the View since it's not aware of Windowing concepts.Pull request checklist
This PR has considered (when applicable):