Use correct length increment for IP_PKTINFO CMsg header #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzikm
changed the title
nibanks
approved these changes
Sep 14, 2022
nibanks
added
OS: Ubuntu
Bug: Platform
|
nice. may be related to alignment... |
csujedihy
pushed a commit
that referenced
this pull request
Sep 14, 2022
rzikm
added a commit
to rzikm/msquic
that referenced
this pull request
Sep 15, 2022
nibanks
pushed a commit
that referenced
this pull request
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Arm32 devices, we encountered an issue where all attemts at connection timeout, closer investigation showed that all
sendmmsgcalls were failing with errno 22. I dug around a bit and it seems that the platform in question (Debian 10 on arm) was checking the expected length againstIP_PKTINFOcontrol header and failed the send. Using correct length for IPv4 and IPv6 solved the issue.More info at dotnet/runtime#75493 (comment)
Testing
Tested on affected platform.
Documentation
N/A